[Lldb-commits] [lldb] r358939 - One small tweak to LocateExecutableScriptingResources - I

[Jason Molenda via lldb-commits]

Author: jmolenda
Date: Mon Apr 22 18:13:27 2019
New Revision: 358939

URL: http://llvm.org/viewvc/llvm-project?rev=358939&view=rev
Log:
One small tweak to LocateExecutableScriptingResources - I
was still stat'ing the possibly-dSYM FileSpec before I
(more cheaply) checked the filepath for telltale dSYM
components.
<rdar://problem/50086007> 

Modified:
    lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp?rev=358939&r1=358938&r2=358939&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp Mon Apr 22 
18:13:27 2019
@@ -80,9 +80,9 @@ FileSpecList PlatformDarwin::LocateExecu
           if (objfile) {
             FileSpec symfile_spec(objfile->GetFileSpec());
             if (symfile_spec && 
-                FileSystem::Instance().Exists(symfile_spec) && 
                 strcasestr (symfile_spec.GetPath().c_str(), 
-                        ".dSYM/Contents/Resources/DWARF") != nullptr) {
+                        ".dSYM/Contents/Resources/DWARF") != nullptr &&
+                FileSystem::Instance().Exists(symfile_spec)) {
               while (module_spec.GetFilename()) {
                 std::string module_basename(
                     module_spec.GetFilename().GetCString());


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits