sgraenitz created this revision.
sgraenitz added reviewers: friss, bogner, beanz.
Herald added subscribers: aprantl, mgorny.
Herald added a project: LLVM.
Extra flexibility for emitting debug info to external files (remains Darwin
only for now).
LLDB needs this functionality to emit a LLDB.framework.dSYM instead of
LLDB.dSYM when building the framework, because the latter could conflict with
the driver's lldb.dSYM when emitted in the same directory on case-insensitive
file systems.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D60862
Files:
llvm/cmake/modules/AddLLVM.cmake
Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1604,14 +1604,21 @@
endif()
endif()
- if(LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR)
- if(APPLE)
- set(output_name "$<TARGET_FILE_NAME:${name}>.dSYM")
+ if(APPLE)
+ if(LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION)
+ set(file_ext ${LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION})
+ else()
+ set(file_ext dSYM)
+ endif()
+
+ set(output_name "$<TARGET_FILE_NAME:${name}>.${file_ext}")
+
+ if(LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR)
set(output_path
"-o=${LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR}/${output_name}")
+ else()
+ set(output_path "-o=${output_name}")
endif()
- endif()
- if(APPLE)
if(CMAKE_CXX_FLAGS MATCHES "-flto"
OR CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-flto")
Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -1604,14 +1604,21 @@
endif()
endif()
- if(LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR)
- if(APPLE)
- set(output_name "$<TARGET_FILE_NAME:${name}>.dSYM")
+ if(APPLE)
+ if(LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION)
+ set(file_ext ${LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION})
+ else()
+ set(file_ext dSYM)
+ endif()
+
+ set(output_name "$<TARGET_FILE_NAME:${name}>.${file_ext}")
+
+ if(LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR)
set(output_path "-o=${LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR}/${output_name}")
+ else()
+ set(output_path "-o=${output_name}")
endif()
- endif()
- if(APPLE)
if(CMAKE_CXX_FLAGS MATCHES "-flto"
OR CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-flto")
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
