labath added a comment.

The fix looks correct, but I am wondering if it wouldn't be possible to test 
this in a more platform-independent manner. Please see inline comment below.



================
Comment at: 
packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py:1-49
+"""
+Read in a library with a version number of 0.0.0, make sure we produce a good 
version.
+"""
+
+from __future__ import print_function
+
+
----------------
Would it be possible to generate this binary via yaml2obj (e.g. compile it 
manually, like you did above, and then yamlize it)? Then, if you avoid running 
the target and just load the module by creating the SBModule object directly 
from a ModuleSpec, you should get a test that is able to run on all platforms, 
and not just darwin.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59913/new/

https://reviews.llvm.org/D59913



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to