jingham added a comment.

It's a little weird that the CommandObjectExpression is telling the REPL what 
its options should be, it would be more natural to go the other way.  Maybe 
have the repl_sp provide a properly set up set of EvaluateExpressionOptions and 
then copy them over to this CommandObjectExpression execution?

Also, as is GetExprOptions is not a very descriptive name for something that's 
specifically setting up Command & EvaluateExpressionOptions for the REPL.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59158/new/

https://reviews.llvm.org/D59158



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to