jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
This seems reasonable to me. Any Host implementation can live off source/Host/common/Symbols.cpp, and only needs to do anything if it wants to augment that behavior. Seen that way, it is not defining API's that are a required step in porting to a new platform. So the API definitions don't need to be specially called out as being required of a Host implementation. And the implementation is still in source/Host so it's clear that this does provide host specific functionality. So that seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58730/new/ https://reviews.llvm.org/D58730 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
