[Lldb-commits] [PATCH] D58699: Adapt the ObjC checker instrumentation to handle objc_msgSend with struct returns

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Expression/IRDynamicChecks.cpp:437
       break;
     case eMsgSend_stret:
       target_object = call_inst->getArgOperand(1);
----------------
move up above for all architectures?


================
Comment at: source/Expression/IRDynamicChecks.cpp:438-439
     case eMsgSend_stret:
       target_object = call_inst->getArgOperand(1);
       selector = call_inst->getArgOperand(2);
       break;
----------------
remove these two lines after moving eMsgSend_stret up with eMsgSend and 
eMsgSend_fpret cases?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58699/new/

https://reviews.llvm.org/D58699



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits