labath marked 2 inline comments as done. labath added inline comments.
================ Comment at: include/lldb/Host/UserIDResolver.h:9 + +#ifndef LLDB_HOST_USERIDRESOLVER_H +#define LLDB_HOST_USERIDRESOLVER_H ---------------- zturner wrote: > I wonder if this class should actually be in Host. While some specific > implementation of it might be host-dependent, the interface itself is not. I > kind of envision at some point in the future having a target that contains > all of our core interfaces that someone can include and re-implement small > pieces of the debugger without having to bring in the entire thing. This is > also nice from a mocking / unittesting perspective. > > So I think this would be better if it were in Utility (or some other > top-level library such as Interfaces) Yes, I've wondered about that too. I went with Host because that was enough to make things work, but I certainly see the case for this being Utility too. I'll move it there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58167/new/ https://reviews.llvm.org/D58167 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
