This revision was automatically updated to reflect the committed changes. Closed by commit rL354922: [lldb] [unittests] Use non-empty format string for Timer() (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.
Changed prior to commit: https://reviews.llvm.org/D58680?vs=188430&id=188437#toc Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58680/new/ https://reviews.llvm.org/D58680 Files: lldb/trunk/unittests/Utility/TimerTest.cpp Index: lldb/trunk/unittests/Utility/TimerTest.cpp =================================================================== --- lldb/trunk/unittests/Utility/TimerTest.cpp +++ lldb/trunk/unittests/Utility/TimerTest.cpp @@ -17,7 +17,7 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat("CAT1"); - Timer t(tcat, ""); + Timer t(tcat, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss; @@ -32,10 +32,10 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat1("CAT1"); - Timer t1(tcat1, ""); + Timer t1(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); // Explicitly testing the same category as above. - Timer t2(tcat1, ""); + Timer t2(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss; @@ -52,10 +52,10 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat1("CAT1"); - Timer t1(tcat1, ""); + Timer t1(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(100)); static Timer::Category tcat2("CAT2"); - Timer t2(tcat2, ""); + Timer t2(tcat2, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss;
Index: lldb/trunk/unittests/Utility/TimerTest.cpp =================================================================== --- lldb/trunk/unittests/Utility/TimerTest.cpp +++ lldb/trunk/unittests/Utility/TimerTest.cpp @@ -17,7 +17,7 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat("CAT1"); - Timer t(tcat, ""); + Timer t(tcat, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss; @@ -32,10 +32,10 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat1("CAT1"); - Timer t1(tcat1, ""); + Timer t1(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); // Explicitly testing the same category as above. - Timer t2(tcat1, ""); + Timer t2(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss; @@ -52,10 +52,10 @@ Timer::ResetCategoryTimes(); { static Timer::Category tcat1("CAT1"); - Timer t1(tcat1, ""); + Timer t1(tcat1, "."); std::this_thread::sleep_for(std::chrono::milliseconds(100)); static Timer::Category tcat2("CAT2"); - Timer t2(tcat2, ""); + Timer t2(tcat2, "."); std::this_thread::sleep_for(std::chrono::milliseconds(10)); } StreamString ss;
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits