labath added a comment.
The overall idea seems fine to me, though I think it would be better to keep
the macros simpler by moving all of the logic into the single `Register` call.
I.e. the Register function would take extra StringRef arguments, which the
macros would fill out. Then you could store the computed signature in the
(possibly renamed) `m_ids` map, instead of having two maps with the same set of
keys. That should save some space too.
================
Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:591
- LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), "Recording ({0})
'{1}'",
+#ifndef LLDB_REPRO_INSTR_TRACE
+ LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), "Recording {0}: {1}",
----------------
aprantl wrote:
> Who defines this macro? I'm asking because it's unusual for LLDB to emit
> anything on stderr.
I'm guessing it's the kind of thing you define by editing the source/cmake
config, when you're really desperate to figure out what's going wrong.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58566/new/
https://reviews.llvm.org/D58566
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
