labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
LGTM. I'd maybe rename InitializeReplay into Replay (i.e., do the merging the other way around), since the `Initialize` part makes me think the replay will not actually commence there. I forgot that we don't return STL objects through the API. It's a shame we have to resort to the `static std::string` hack. Another option would be to ConstStringify the string, but as these are functions that are to be called just once, this should do too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58410/new/ https://reviews.llvm.org/D58410 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
