sgraenitz accepted this revision.
sgraenitz added a subscriber: hans.
sgraenitz added a comment.
This revision is now accepted and ready to land.

@serge-sans-paille After all, it appears to me that your issue is caused by 
something else, but if this change fixes it, I am not against taking it for 
now. It shouldn't do any harm. Please get in touch with @hans if this is really 
relevant for `release_80`.

However, please note that your patch base is not up-to-date with `master` [1] 
or `release_80` [2] branches. The meanwhile changes shouldn't affect the 
`dsymutil` or `llc` targets, but maybe it's a hint towards the actual problem.
Also note that the lines you want to modify are there since May [3] and 
September [4] respectively, so it's been this way already in the 7.0 release.

(I am off till early March and will only check my inbox rarely. Hope 
everything's gonna work out well.)

[1] https://github.com/llvm-mirror/lldb/blob/master/lit/CMakeLists.txt
[2] https://github.com/llvm-mirror/lldb/blob/release_80/lit/CMakeLists.txt
[3] https://reviews.llvm.org/rL331447#change-GVDgVmL1F2CA
[4] https://reviews.llvm.org/rL342733#change-GVDgVmL1F2CA


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58193/new/

https://reviews.llvm.org/D58193



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to