clayborg added inline comments.

================
Comment at: source/Target/Process.cpp:2639
+  ModuleSP module_sp(new Module(
+      file_spec, GetTarget().GetExecutableModule()->GetArchitecture()));
   if (module_sp) {
----------------
So if you have a target that is set to "aarch64-linux-android', and you have 
"aarch64---" in your object file/module, you would want to merge the missing 
bits from the target to augment the module's architecture so it grabs the 
"linux-android" bits. So I do believe MergeFrom should be used to augment the 
Module's architecture.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58405/new/

https://reviews.llvm.org/D58405



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to