labath accepted this revision.
labath added a comment.
I don't remember if this tests some super-critical functionality (i.e., whether
you will be able to function reasonably without it), but in case it does, it
should be fairly easy to get this class to use one of the other event sources
(pselect, ppoll), if kevent is not functioning well on netbsd.
And to answer your IRC question, gtest has a concept of a disabled test, which
you do by prefixing the test with "DISABLED_". The typical way to achieve that
would be via something like:
#ifdef __NetBSD__
#define SKIP_ON_NETBSD(x) DISABLED_ ## x
#else
#define SKIP_ON_NETBSD(x) x
#endif
TEST(foo, SKIP_ON_NETBSD(bar)) { ... }
However, that is very tedious, so people usually do exactly what you have done
here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57912/new/
https://reviews.llvm.org/D57912
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
