clayborg added a comment.

Check the comment about m_platform_file



================
Comment at: include/lldb/Core/Module.h:176-177
+
+    // Also update the module FileSpec.
+    module_sp->m_file = module_sp->m_objfile_sp->GetFileSpec();
+    return std::move(module_sp);
----------------
Why do we need to update the m_file? m_platform_file is the path of the module 
as it is known the the remote system, so if m_file differs from the object 
file's file spec, we might want to shuffle, m_file into m_platform_file first 
and then overwrite it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57751/new/

https://reviews.llvm.org/D57751



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to