mehdi_amini added a comment. LGTM, but for one comment that requires a fix I believe (lld on Windows)
================ Comment at: libcxx/docs/BuildingLibcxx.rst:47 - * ``cd build`` - * ``cmake -G <generator> [options] <path to llvm sources>`` ---------------- So nice to see these steps going away :) ================ Comment at: libcxx/docs/BuildingLibcxx.rst:57 $ cd where-you-want-libcxx-to-live - $ # Check out llvm, libc++ and libc++abi. - $ ``svn co http://llvm.org/svn/llvm-project/llvm/trunk llvm`` - $ ``svn co http://llvm.org/svn/llvm-project/libcxx/trunk libcxx`` - $ ``svn co http://llvm.org/svn/llvm-project/libcxxabi/trunk libcxxabi`` + $ # Check out the sources (includes everything, but we'll only use libcxx) + $ ``git clone https://github.com/llvm/llvm-project.git`` ---------------- Wonder if it is worth mentioning somewhere how to sparse-checkout? ================ Comment at: libcxxabi/www/index.html:86 <li><code>mkdir build && cd build</code></li> - <li><code>cmake .. # on linux you may need to prefix with CC=clang CXX=clang++</code></li> + <li><code>cmake -DLLVM_ENABLE_PROJECTS=libcxxabi ../llvm # on linux you may need to prefix with CC=clang CXX=clang++</code></li> <li><code>make</code></li> ---------------- Do you now if prefixing with CC is equivalent to -DCMAKE_C_COMPILER? ================ Comment at: lld/docs/getting_started.rst:71 + $ cd llvm-project/build (out of source build required) + $ cmake -G "Visual Studio 11" ../llvm ---------------- Missing -DLLVM_ENABLE_PROJECTS=lld here I believe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57330/new/ https://reviews.llvm.org/D57330 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
