davide added inline comments.
================
Comment at:
packages/Python/lldbsuite/test/expression_command/radar_47565290/TestClassTemplateSpecializationParametersHandling.py:5-6
+
+from __future__ import print_function
+
+
----------------
I think this is not needed.
================
Comment at: source/Symbol/ClangASTContext.cpp:1572
+ }
+ } else if (identifier_info) {
template_param_decls.push_back(TemplateTypeParmDecl::Create(
----------------
aprantl wrote:
> Looks like this is the same code as above. Could this be organized
> differently to avoid duplicating the code? (I didn't look whether these are
> all different constructors, so maybe this is already as good as it gets)
Why this code block became conditional of `if (identifier_info)` ?
I understand the size check above, but can you elaborate on the need for this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57363/new/
https://reviews.llvm.org/D57363
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
