clayborg added inline comments.
================
Comment at: source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp:43
+
+namespace dwarf {
+enum regnums {
----------------
add "namespace {" around all of this
================
Comment at: source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp:52
+};
+} // namespace dwarf
+
----------------
Don't end this namespace here? It starts up again on line 70. I would move the
#define statements above the dwarf namespace
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55724/new/
https://reviews.llvm.org/D55724
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
