Author: xiaobai Date: Tue Jan 15 16:09:50 2019 New Revision: 351276 URL: http://llvm.org/viewvc/llvm-project?rev=351276&view=rev Log: [lldb-mi] Remove use of dialog box
Summary: This really is only implemented on Windows, and it requires us to pull in User32. This was only useful when debugging on lldb-mi on Windows, and there doesn't seem to be a good reason why using a dialog box is better than what exists for other platforms. Reviewers: zturner, jingham, compnerd Subscribers: ki.stfu Differential Revision: https://reviews.llvm.org/D56755 Modified: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp lldb/trunk/tools/lldb-mi/MIUtilDebug.h Modified: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIDriverMain.cpp?rev=351276&r1=351275&r2=351276&view=diff ============================================================================== --- lldb/trunk/tools/lldb-mi/MIDriverMain.cpp (original) +++ lldb/trunk/tools/lldb-mi/MIDriverMain.cpp Tue Jan 15 16:09:50 2019 @@ -165,11 +165,7 @@ bool DriverSystemShutdown(const bool vbA //-- int main(int argc, char const *argv[]) { #if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG -#ifdef _WIN32 - CMIUtilDebug::ShowDlgWaitForDbgAttach(); -#else CMIUtilDebug::WaitForDbgAttachInfinteLoop(); -#endif // _WIN32 #endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG llvm::StringRef ToolName = argv[0]; Modified: lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp?rev=351276&r1=351275&r2=351276&view=diff ============================================================================== --- lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp (original) +++ lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp Tue Jan 15 16:09:50 2019 @@ -39,25 +39,6 @@ CMIUtilDebug::~CMIUtilDebug() {} //++ //------------------------------------------------------------------------------------ -// Details: Show a dialog to the process/application halts. It gives the -// opportunity to -// attach a debugger. -// Type: Static method. -// Args: None. -// Return: None. -// Throws: None. -//-- -void CMIUtilDebug::ShowDlgWaitForDbgAttach() { - const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort()); -#ifdef _WIN32 - ::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK); -#else -// ToDo: Implement other platform version of an Ok to continue dialog box -#endif // _WIN32 -} - -//++ -//------------------------------------------------------------------------------------ // Details: Temporarily stall the process/application to give the programmer the // opportunity to attach a debugger. How to use: Put a break in the // programmer Modified: lldb/trunk/tools/lldb-mi/MIUtilDebug.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MIUtilDebug.h?rev=351276&r1=351275&r2=351276&view=diff ============================================================================== --- lldb/trunk/tools/lldb-mi/MIUtilDebug.h (original) +++ lldb/trunk/tools/lldb-mi/MIUtilDebug.h Tue Jan 15 16:09:50 2019 @@ -24,7 +24,6 @@ class CMICmnLog; class CMIUtilDebug { // Statics: public: - static void ShowDlgWaitForDbgAttach(); static void WaitForDbgAttachInfinteLoop(); // Methods: _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
