amccarth added inline comments.

================
Comment at: 
lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1289
+    if (type)
+      (void)type->GetFullCompilerType();
+  }
----------------
The body of this loop is a little odd because it's disposing of all the results 
and is just going through the motions to get side-effects to happen.  I realize 
the root problem is with the design of the API.  Perhaps a comment for the 
uninitiated might point future readers in the right direction.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56461/new/

https://reviews.llvm.org/D56461



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to