labath added a comment.
Looks very nice. Thanks.
================
Comment at: include/lldb/Host/windows/PipeWindows.h:52
+ lldb::pipe_t GetReadPipe() const { return lldb::pipe_t(m_read); }
+ lldb::pipe_t GetWritePipe() const { return lldb::pipe_t(m_write); }
----------------
missing `override` (that will likely be flagged as a warning by clang)?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56234/new/
https://reviews.llvm.org/D56234
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
