labath added a comment. I would definitely encourage using something better than the file checksum as UUID, if at all possible.
================ Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:139 + uuid = + UUID::fromOptionalData(llvm::ArrayRef<uint8_t>(Result->Bytes)); + } ---------------- I think this should be `fromData`. The `Optional` is there to give special meaning to an all-zero checksum, but you don't need that here. Just because the md5 checksum comes out as all-zero, it doesn't mean it is not valid. PS: I am responsible for the existence of this function, so I am to blame for any confusion. If you have any idea, how to make this api more clear, I'd like to hear it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
