labath added a reviewer: labath.
labath added a comment.

Forgive my ignorance, but what makes getenv unportable? llvm uses in a bunch of 
places so it can't be that bad... Is it some wide string thingy?

Regardless, using the lldb function for that seems fine, but if I remember 
correctly, each GetEnvironment call causes us to reparse the entire environment 
block. So it would be nice to just call it once in this function and then query 
that object for what we need.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56230/new/

https://reviews.llvm.org/D56230



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to