aprantl added inline comments.

================
Comment at: lit/Reproducer/Functionalities/Inputs/stepping.c:8
+//
+//===----------------------------------------------------------------------===//
+#include <stdio.h>
----------------
Why does only this file have a header?


================
Comment at: lit/Reproducer/Functionalities/Inputs/stepping.c:9
+//===----------------------------------------------------------------------===//
+#include <stdio.h>
+
----------------
If we don't need stdio then removing it will speed up compile time. You can 
still fwd-declare puts or printf.


================
Comment at: lit/Reproducer/Functionalities/TestStepping.test:39
+# CHECK: 1 breakpoints disabled.
+# CHECK: 1 breakpoints disabled.
+
----------------
perhaps copy the commands in here so it is easier to understand what is being 
checked for?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55626/new/

https://reviews.llvm.org/D55626



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to