lemo marked an inline comment as done.
lemo added inline comments.
================
Comment at: source/Commands/CommandObjectTarget.cpp:4246
if (symbol_file) {
- ObjectFile *object_file = symbol_file->GetObjectFile();
----------------
note I had to bypass this check: we don't (yet) have a ObjectFilePDB so the
SymbolFileNativePDB always points to the associated PE binary.
the check itself seems valuable as a diagnostic but not strictly required.
Should I add a TODO comment and/or open a bug to revisit this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55142/new/
https://reviews.llvm.org/D55142
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
