[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31
 
-  bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo &region_info);
+  void Reserve(size_t capacity);
 
----------------
zturner wrote:
> clayborg wrote:
> > This you can add, but std::vector implementations are quite efficient and I 
> > doubt this is really needed?
> std::vector is as efficient as it can be without additional hints from the 
> user, but reserve is a very useful optimization in general.
Agreed but this doesn't need to be in the public API as there is no real need.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55472/new/

https://reviews.llvm.org/D55472



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits