sgraenitz added a comment. >> It's not introduced in this patch, but the part that struck me as a hack has >> the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that >> could be removed? > > I agree, this is unfortunate. The problem is that we only have a single > global setting for the identity in LLVM and we want `lldb_codesign` as the > default for LLDB.
Now that I think about it again, I could at least print a warning if `LLVM_CODESIGNING_IDENTITY ` is not empty when force-overwriting. What do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
