sgraenitz marked an inline comment as done. sgraenitz added inline comments.
================ Comment at: cmake/modules/debugserverConfig.cmake:2 +# Duplicate options from LLDBConfig that are relevant for debugserver Standalone builds. + +option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) ---------------- aprantl wrote: > I don't know CMake enough, but would it be feasible to have both file > #include a fragment with the shared code? Yes I think this makes sense as soon as the number of duplicates grows. BTW I double-checked and we don't use LLDB_VERSION in debugserver standalone yet, so for now I won't add it. Updated the review accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55320/new/ https://reviews.llvm.org/D55320 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
