clayborg added a comment. Missed an inline comment on last comment
================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:311 + dw_addr_t addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_addr_base, 0); + SetAddrBase(addr_base); ---------------- Use LLDB_INVALID_ADDRESS instead of zero as zero could be a valid base address. ``` dw_addr_t addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_addr_base, LLDB_INVALID_ADDRESS); ``` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
