shafik added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329
+std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti, TpiStream &tpi) {
+ if (ti.isSimple()) {
----------------
lemo wrote:
> Just a suggestion: I'm not a big fan of returning std::pair<>. I'd use a
> simple struct instead.
I have to concur on this, although the use of `std::tie` helps alleviate the
pain i.e. no `second` and `first` it does feel more verbose on the calling side
to declare two variables and then do the tie and it relies on the calling to
choose meaningful names which can't be relied on if the use spreads and people
are not as careful.
https://reviews.llvm.org/D54452
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
