OK, thanks. Please add an explanation next time you revert something.

Best,

--
Davide
On Fri, Nov 9, 2018 at 8:10 AM Kadir Çetinkaya <kadir...@google.com> wrote:
>
> It was reverted in base repo, https://reviews.llvm.org/rL346500
>
> On Fri, Nov 9, 2018 at 5:09 PM Davide Italiano <dccitali...@gmail.com> wrote:
>>
>> On Fri, Nov 9, 2018 at 7:20 AM Kadir Cetinkaya via lldb-commits
>> <lldb-commits@lists.llvm.org> wrote:
>> >
>> > Author: kadircet
>> > Date: Fri Nov  9 07:18:02 2018
>> > New Revision: 346502
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=346502&view=rev
>> > Log:
>> > revert rL346478
>> >
>>
>> This message isn't explaining why you reverted. Ca you please elaborate?
>>
>> --
>> Davide
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to