JDevlieghere added a comment.

In https://reviews.llvm.org/D54135#1288254, @krytarowski wrote:

> Why? We already put a lot of effort into reusing code from LLVM.


This is still using code from LLVM, the `FileSystem` class is just an 
abstraction in between:

1. It uses LLVM's virtual file system. The VFS is stateful and the FileSystem 
class maintains this state. If you don't specify a virtual file system it uses 
the "real" file system (the default).
2. It has convenience methods for FileSpecs, so that you don't have to convert 
them at every call site. These functions used to be methods in the FileSpec 
class, something we wanted to get rid of for a while because conceptually the 
latter is just a "smart path".

I started doing all this work to support reproducers in LLDB. We'll need a 
bunch of files that won't live at their original location and the VFS makes it 
possible to deal with that transparently.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54135



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to