shafik added inline comments.
================
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:336
+ llvm::itanium_demangle::Node *parseType() {
+ if (llvm::StringRef(First, Last - First).startswith(Search)) {
+ Result += llvm::StringRef(Written, First - Written);
----------------
Can you just use `numLeft()` here? It would be less opaque.
================
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:337
+ if (llvm::StringRef(First, Last - First).startswith(Search)) {
+ Result += llvm::StringRef(Written, First - Written);
+ Result += Replace;
----------------
also `First - Written` is used twice but it is not obvious what the means,
naming it via a member function might be helpful.
https://reviews.llvm.org/D54074
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
