JDevlieghere added a comment. In https://reviews.llvm.org/D53532#1280018, @labath wrote:
> In https://reviews.llvm.org/D53532#1279022, @JDevlieghere wrote: > > > Address Pavel's feedback: > > > > - Change to `Initialize` method which can only be called once. > > > I suppose this is slightly better, but what I meant was to have a `static` > (like all other functions with the same name) `Initialize` function, which > has to be called before the first call to `Instance()`. During normal > startup, this could be called from `SystemInitializer`, but I am not sure how > would that work for record/replay (that's why I was asking how you planned to > initialize those). It would require to setup the record/replay machinery very > early on, which may be tricky. But on the other hand, you probably want to > initialize these as early as possible anyway. > > Do you think something like that would be possible? Alright, I see what you mean. You know more about the architecture, but it looks like we initialize the system before even reading the command line arguments in the driver. I have to read the reproducer before I can set the appropriate file system, so I'm not sure if this is possible. https://reviews.llvm.org/D53532 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
