clayborg added a comment. In https://reviews.llvm.org/D53368#1276152, @aleksandr.urakov wrote:
> Yes, I'll implement it tomorrow (I'm already OOO now), thanks. But is it > really necessary to check the number of symbols added if we must to calculate > / finalize the symtab after getting it from object file anyway? May be just > always do it after creation and processing by the symbol file? For each > symtab it will be done just once because of caching. yes, fine to still have void and always call symtab.CalculateSymbolSizes(); and symtab.Finalize() only in the symbol vendor. Find the other places this is called in the ObjectFile plug-ins and remove them and do them once in Symbol vendor when we fetch the symtab for the first time https://reviews.llvm.org/D53368 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
