clayborg added a comment.

See inlined comment.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:287
+      m_has_children : 1;
   uint32_t m_abbr_idx : DIE_ABBR_IDX_BITSIZE,
                         m_tag : 16; // A copy of the DW_TAG value so we don't
----------------
Might be worth changing these to be uint16_t, removing DIE_ABBR_IDX_BITSIZE and 
changing any code that was using that to make sure that the value is <= 
UINT16_MAX:

```
uint16_t m_abbr_idx;
uint16_t m_tag;
```


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53321



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to