vsk added inline comments.

================
Comment at: packages/Python/lldbsuite/test/dosep.py:1693
     for core in cores:
         dst = core.replace(test_directory, "")[1:]
         dst = dst.replace(os.path.sep, "-")
----------------
Instead of redefining test_directory, please use 'test_subdir' in the call to 
core.replace. That leaves the logic to find the right path in 
configuration.get_absolute_path_to_root_test_dir.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51874



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to