aprantl added inline comments.
================
Comment at: lldb/source/Target/StackFrameList.cpp:331
+ dfs(next_callee);
+ if (ambiguous)
+ return;
----------------
On what path can this happen? Aren't all paths that set `ambiguous=true`
returning immediately?
================
Comment at: lldb/source/Target/StackFrameList.cpp:404
+ callee->CalculateSymbolContext(&sc);
+ StackFrameSP synth_frame{new StackFrame(
+ m_thread.shared_from_this(), frame_idx, concrete_frame_idx, cfa,
----------------
`auto synth_frame = llvm::make_unique<StackFrame>(..)` ?
https://reviews.llvm.org/D50478
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
