tatyana-krasnukha updated this revision to Diff 166507.
tatyana-krasnukha added a comment.
LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't
propagate lldbHost's include directories to lldbCore and lldbInterpreter.
For lldbHost itself, I had to use PUBLIC, because its sources require includes
libedit headers and unittests inherit this path too.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51999
Files:
source/Core/CMakeLists.txt
source/Host/CMakeLists.txt
source/Interpreter/CMakeLists.txt
Index: source/Interpreter/CMakeLists.txt
===================================================================
--- source/Interpreter/CMakeLists.txt
+++ source/Interpreter/CMakeLists.txt
@@ -55,3 +55,7 @@
LINK_COMPONENTS
Support
)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbInterpreter PRIVATE ${libedit_INCLUDE_DIRS})
+endif()
Index: source/Host/CMakeLists.txt
===================================================================
--- source/Host/CMakeLists.txt
+++ source/Host/CMakeLists.txt
@@ -174,3 +174,7 @@
Object
Support
)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbHost PUBLIC ${libedit_INCLUDE_DIRS})
+endif()
Index: source/Core/CMakeLists.txt
===================================================================
--- source/Core/CMakeLists.txt
+++ source/Core/CMakeLists.txt
@@ -80,3 +80,7 @@
# Needed to properly resolve references in a debug build.
# TODO: Remove once we have better layering
set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 4)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbCore PRIVATE ${libedit_INCLUDE_DIRS})
+endif()
Index: source/Interpreter/CMakeLists.txt
===================================================================
--- source/Interpreter/CMakeLists.txt
+++ source/Interpreter/CMakeLists.txt
@@ -55,3 +55,7 @@
LINK_COMPONENTS
Support
)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbInterpreter PRIVATE ${libedit_INCLUDE_DIRS})
+endif()
Index: source/Host/CMakeLists.txt
===================================================================
--- source/Host/CMakeLists.txt
+++ source/Host/CMakeLists.txt
@@ -174,3 +174,7 @@
Object
Support
)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbHost PUBLIC ${libedit_INCLUDE_DIRS})
+endif()
Index: source/Core/CMakeLists.txt
===================================================================
--- source/Core/CMakeLists.txt
+++ source/Core/CMakeLists.txt
@@ -80,3 +80,7 @@
# Needed to properly resolve references in a debug build.
# TODO: Remove once we have better layering
set_target_properties(lldbCore PROPERTIES LINK_INTERFACE_MULTIPLICITY 4)
+
+if (NOT LLDB_DISABLE_LIBEDIT)
+ target_include_directories(lldbCore PRIVATE ${libedit_INCLUDE_DIRS})
+endif()
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
