jankratochvil added a comment. In https://reviews.llvm.org/D51578#1233518, @clayborg wrote:
> Is there a reason we need DWARFConcatenatingDataExtractor? Can we just put > all functionality into DWARFDataExtractor? OK, I will try it that way. > Also is there a reason we need to pass the block data in code such as: > > const DWARFDataExtractor &debug_info_data = > die.GetData().GetDWARFDataExtractor(form_value.BlockData()); Otherwise I would have to refactor more functions (using that `debug_info_data`) to use `DWARFConcatenatingDataExtractor` instead of current `DWARFDataExtractor`. But given you propose to radically merge both together I agree that `GetDWARFDataExtractor` may no longer be needed. I am sorry I will be now for 2 weeks away. Repository: rLLDB LLDB https://reviews.llvm.org/D51578 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
