zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:274
- auto class_parent_id = raw.getClassParentId();
- if (auto class_parent = session.getSymbolById(class_parent_id))
- return class_parent;
+ switch (tag) {
+ case PDB_SymType::Function:
----------------
Can you put a comment here?
```
// For items that are nested inside of a class, return the class that it is
nested inside of. Note that only certain items can be nested inside of classes.
```
================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:281
+ case PDB_SymType::Typedef:
+ case PDB_SymType::BaseClass: {
+ auto class_parent_id = raw.getClassParentId();
----------------
Do you want to handle `VTable` here?
================
Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:290-292
+ switch (tag) {
+ case PDB_SymType::Block:
+ case PDB_SymType::Data: {
----------------
```
// Otherwise, if it is nested inside of a function, return the function. Note
that only certain items can be nested inside of functions.
```
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51967
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
