clayborg requested changes to this revision.
clayborg added a comment.
Patch looks good. A few fixes mentioned in inlined comments. And I am unsure
how the test suite will run with various compilers if they don't support the
-gdwarf-5 flag. We might need to run obj2yaml on a binary and then yaml2obj it
for the test to ensure we can run the test. We might be able to just
symbolicate a few addresses in the test instead of requiring us to run
something.
================
Comment at: include/lldb/lldb-enumerations.h:675
eSectionTypeDWARFDebugNames, // DWARF v5 .debug_names
+ eSectionTypeDWARFDebugLineStr, // DWARF v5 .debug_line_str
eSectionTypeOther
----------------
Add this after the eSectionTypeOther for backward compatibility.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442
+ ReadDescriptors(debug_line_data, offset_ptr);
+ uint8_t dirCount = debug_line_data.GetU8(offset_ptr);
+ for (int i = 0; i < dirCount; ++i) {
----------------
We might verify that this is indeed correct by looking at compiler sources.
Seems weird to limit dirs to 255
https://reviews.llvm.org/D51935
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
