[Lldb-commits] [lldb] r339205 - [StackFrame] Add more clarifying comments to StackFrameList (NFC)

[Vedant Kumar via lldb-commits]

Author: vedantk
Date: Tue Aug  7 16:48:25 2018
New Revision: 339205

URL: http://llvm.org/viewvc/llvm-project?rev=339205&view=rev
Log:
[StackFrame] Add more clarifying comments to StackFrameList (NFC)

Modified:
    lldb/trunk/source/Target/StackFrameList.cpp

Modified: lldb/trunk/source/Target/StackFrameList.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrameList.cpp?rev=339205&r1=339204&r2=339205&view=diff
==============================================================================
--- lldb/trunk/source/Target/StackFrameList.cpp (original)
+++ lldb/trunk/source/Target/StackFrameList.cpp Tue Aug  7 16:48:25 2018
@@ -234,6 +234,9 @@ void StackFrameList::GetOnlyConcreteFram
     // Done unwinding.
     m_concrete_frames_fetched = UINT32_MAX;
   }
+
+  // Don't create the frames eagerly. Defer this work to GetFrameAtIndex,
+  // which can lazily query the unwinder to create frames.
   m_frames.resize(num_frames);
 }
 
@@ -567,9 +570,6 @@ StackFrameSP StackFrameList::GetFrameWit
         if ((*pos)->GetStackID() == stack_id)
           return *pos;
       }
-
-      //            if (m_frames.back()->GetStackID() < stack_id)
-      //                frame_idx = m_frames.size();
     }
     do {
       frame_sp = GetFrameAtIndex(frame_idx);


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits