jingham added a comment.

This implementation forces an extra lookup when the line number slides.  For 
instance, if there were only one line match, but it was not exact, you're going 
to look up the exact address, fail, then look it up with exact = false.

Wouldn't it be more efficient to look with exact = false first, then reset the 
line you are looking for to whatever you got back, and continue with the 
exact=true search you do for the other line numbers.


https://reviews.llvm.org/D50304



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits... Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits
    • [Lldb-co... Jim Ingham via Phabricator via lldb-commits
    • [Lldb-co... Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits
    • [Lldb-co... Jim Ingham via Phabricator via lldb-commits
    • [Lldb-co... Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits
    • [Lldb-co... Davide Italiano via Phabricator via lldb-commits

Reply via email to