labath added a comment. Which version is this patch based on? The line numbers don't seem to match what I see on master.
Could you rebase the patch to master, and upload the patch with a full diff (e.g. via `git diff -U9999`, see https://llvm.org/docs/Phabricator.html#id3). ================ Comment at: include/lldb/Core/ModuleList.h:545 + bool always_create = false, + const char* sysroot = nullptr); static bool RemoveSharedModule(lldb::ModuleSP &module_sp); ---------------- Please make this an `llvm::StringRef` (and then change `AsCString` to `GetStringRef` below). Repository: rL LLVM https://reviews.llvm.org/D49685 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
