jingham added a comment.

This patch looks fine, I agree with Pavel the direction is good.  It seems like 
you would reduce a bunch of boiler-plate if you changed over 
InvokeCommonCompletionCallbacks to take a CompletionRequest.  Was there 
something that blocked you from doing that?


https://reviews.llvm.org/D48796



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to