friss added inline comments.

================
Comment at: 
packages/Python/lldbsuite/test/expression_command/xvalue/TestXValuePrinting.py:32
+        self.assertTrue(value.GetError().Success())
+        self.assertEqual(value.GetValueAsUnsigned(), 0)
+
----------------
Could you use a different value than 0? Getting a random zero from memory seems 
to easy. It would be better to test a real string.


https://reviews.llvm.org/D48303



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to