Author: apolyakov Date: Fri Jun 15 13:20:39 2018 New Revision: 334860 URL: http://llvm.org/viewvc/llvm-project?rev=334860&view=rev Log: Revert "[lldb-mi] Add overload method for setting an error"
Summary: This reverts commit r334245 because it duplicates functionality of Status::AsCString used in SBError. Reviewers: aprantl, clayborg Reviewed By: clayborg Subscribers: lldb-commits, ki.stfu Differential Revision: https://reviews.llvm.org/D48212 Modified: lldb/trunk/tools/lldb-mi/MICmdBase.cpp lldb/trunk/tools/lldb-mi/MICmdBase.h Modified: lldb/trunk/tools/lldb-mi/MICmdBase.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.cpp?rev=334860&r1=334859&r2=334860&view=diff ============================================================================== --- lldb/trunk/tools/lldb-mi/MICmdBase.cpp (original) +++ lldb/trunk/tools/lldb-mi/MICmdBase.cpp Fri Jun 15 13:20:39 2018 @@ -214,23 +214,6 @@ void CMICmdBase::SetError(const CMIUtilS //++ //------------------------------------------------------------------------------------ -// Details: Short cut function to enter error information into the command's -// metadata object and set the command's error status. -// Type: Method. -// Args: error - (R) Command result description. -// Return: None. -// Throws: None. -//-- -void CMICmdBase::SetError(const lldb::SBError &error) { - const char *error_cstr = error.GetCString(); - if (error_cstr) - SetError(error_cstr); - else - SetError("unknown error"); -} - -//++ -//------------------------------------------------------------------------------------ // Details: Ask a command to provide its unique identifier. // Type: Method. // Args: A unique identifier for this command class. Modified: lldb/trunk/tools/lldb-mi/MICmdBase.h URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-mi/MICmdBase.h?rev=334860&r1=334859&r2=334860&view=diff ============================================================================== --- lldb/trunk/tools/lldb-mi/MICmdBase.h (original) +++ lldb/trunk/tools/lldb-mi/MICmdBase.h Fri Jun 15 13:20:39 2018 @@ -12,8 +12,6 @@ // C Includes // C++ Includes // Other libraries and framework includes -#include "lldb/API/SBError.h" - // Project includes #include "MICmdArgSet.h" #include "MICmdData.h" @@ -82,7 +80,6 @@ public: // Methods: protected: void SetError(const CMIUtilString &rErrMsg); - void SetError(const lldb::SBError &error); template <class T> T *GetOption(const CMIUtilString &vStrOptionName); bool ParseValidateCmdOptions(); _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
