xiaobai added inline comments.
================
Comment at: CMakeLists.txt:145
+ add_dependencies(lldb-suite lldb-framework)
+elseif()
+ if (LLDB_CAN_USE_LLDB_SERVER)
----------------
compnerd wrote:
> Shouldn't this be `else()`?
Yup
================
Comment at: CMakeLists.txt:176
+ if (LLDB_BUILD_FRAMEWORK)
+ # The target to install libLLDB needs to depend on finish swig so that
the
+ # framework build properly copies over the Python files.
----------------
compnerd wrote:
> "finish swig"?
Should be "finish_swig"
================
Comment at: cmake/modules/LLDBFramework.cmake:5
+file(GLOB root_public_headers ${LLDB_SOURCE_DIR}/include/lldb/lldb-*.h)
+file(GLOB root_private_headers
${LLDB_SOURCE_DIR}/include/lldb/lldb-private-*.h)
+list(REMOVE_ITEM root_public_headers ${root_private_headers})
----------------
compnerd wrote:
> Globs are generally frowned upon for dependency tracking issues.
I see. This code was moved from somewhere else and written by somebody else. My
CMake is somewhat weak, how would you do this instead?
https://reviews.llvm.org/D48060
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
