clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Just one nit you can choose to fix or not. ================ Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:39-41 + if (!unit) + continue; + if (m_units_to_avoid.find(unit->GetOffset()) != m_units_to_avoid.end()) ---------------- Simpler code: ``` if (!unit || m_units_to_avoid.count(unit->GetOffset()) continue; ``` https://reviews.llvm.org/D47832 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
