labath added inline comments.
================
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:384
if (nThreadId != UINT64_MAX)
- strCmd += CMIUtilString::Format(" %llu", nThreadId);
- rDebugger.GetCommandInterpreter().HandleCommand(strCmd.c_str(), m_lldbResult,
- false);
+ rSessionInfo.GetProcess().GetThreadByID(nThreadId).StepOver();
+ else
----------------
It looks like this branch is not covered by the test. Also, do we care about
what happens when the client specifies an invalid thread id?
(I'm mainly pointing these out because these seem like they would be hard to
test in the current framework, the thread ids being unpredictable and all.)
https://reviews.llvm.org/D47797
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
